Global interpretation of comments within tagged template literals

lightmare · September 30, 2021, 3:52pm

Consider the implications of changing template literal parsing rules, for existing programs:

babel/babel/blob/89cab4311ce6dea0090d5819a721a1269765d6ec/scripts/generators/tsconfig.js#L34

    
      
            ...getTsPkgs("eslint"),
            ...getTsPkgs("codemods"),
          ];
          
          
fs.writeFileSync(
            path.resolve(root, `tsconfig.json`),
            "/* This file is automatically generated by scripts/generators/tsconfig.js */\n" +
              JSON.stringify(
                {
                  extends: "./tsconfig.base.json",
                  include: tsPkgs.map(({ relative }) => `${relative}/src/**/*.ts`),
                  compilerOptions: {
                    paths: Object.fromEntries(
                      tsPkgs.map(({ name, relative }) => [name, [`${relative}/src`]])
                    ),
                  },
                },
                null,
                2
              )
          );

github.com

babel/babel/blob/89cab4311ce6dea0090d5819a721a1269765d6ec/packages/babel-generator/src/printer.ts#L651

    
      
          if (
            lastCharCode !== charCodes.leftSquareBracket &&
            lastCharCode !== charCodes.leftCurlyBrace
          ) {
            this.space();
          }
          
          
let val =
            !isBlockComment && !this._noLineTerminator
              ? `//${comment.value}\n`
              : `/*${comment.value}*/`;
          
          
if (isBlockComment && this.format.indent.adjustMultilineComment) {
            const offset = comment.loc?.start.column;
            if (offset) {
              const newlineRegex = new RegExp("\\n\\s{1," + offset + "}", "g");
              val = val.replace(newlineRegex, "\n");
            }
          
          
  const indentSize = Math.max(
              this._getIndent().length,

github.com

babel/babel/blob/89cab4311ce6dea0090d5819a721a1269765d6ec/packages/babel-types/scripts/generators/typescript-legacy.js#L131

    
      
          for (const typeName of t.TYPES) {
            const isDeprecated = !!t.DEPRECATED_KEYS[typeName];
            const realName = isDeprecated ? t.DEPRECATED_KEYS[typeName] : typeName;
          
          
  const result =
              t.NODE_FIELDS[realName] || t.FLIPPED_ALIAS_KEYS[realName]
                ? `node is ${realName}`
                : "boolean";
          
          
  if (isDeprecated) {
              lines.push(`/** @deprecated Use \`is${realName}\` */`);
            }
            lines.push(
              `export function is${typeName}(node: object | null | undefined, opts?: object | null): ${result};`
            );
          
          
  if (isDeprecated) {
              lines.push(`/** @deprecated Use \`assert${realName}\` */`);
            }
            lines.push(
              `export function assert${typeName}(node: object | null | undefined, opts?: object | null): void;`

Topic		Replies	Views
Defining dynamic comments on the fly 💡 Ideas proposal	28	970	October 1, 2021
Improve sub-lange support for template literals 💡 Ideas	29	956	December 3, 2022
Comments in template literals `${/* comment */}` 💡 Ideas	9	134	March 5, 2025
Template Literals Juxtaposition and String.join 💡 Ideas proposal	7	443	July 20, 2021
Proposal: ESX as core JS feature 💡 Ideas proposal	167	7754	July 12, 2024

Global interpretation of comments within tagged template literals

Related topics